RFR: 8309751: Duplicate constant pool entries added during default method processing [v4]

[David Holmes]

On Mon, 8 Apr 2024 22:18:36 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This uses Ashutosh's patch to avoid adding duplicate constant pool entries during default method processing, with one change to make it conditional if not needed. I tested this locally and started writing a test, but writing a test is more difficult because duplicate constant pool entries don't actually violate the spec.
>> 
>> Tested with tier1-4 and ran some startup performance benchmarks on the patch.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Rename hash back and add a comment.

This seems reasonable to me, but I am not that familiar with the code.

One minor nit.

Thanks.

src/hotspot/share/classfile/bytecodeAssembler.cpp line 38:

> 36: void BytecodeConstantPool::init() {
> 37:   for (int i = 1; i < _orig->length(); i++) {
> 38:     bool new_entry = false;

This is unused.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18548#pullrequestreview-1988085767
PR Review Comment: https://git.openjdk.org/jdk/pull/18548#discussion_r1556871626