RFR: 8328630: Add logging when needed symbols in dll are missing. [v6]

[Hamlin Li]

On Wed, 3 Apr 2024 12:28:13 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi, please consider this additional logging.
>> 
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use SetLastError to clear error

Thanks for adding this, it's helpful.

Just some minor comments.

src/hotspot/os/posix/os_posix.cpp line 720:

> 718:     // It is possible that we found a NULL symbol, hence no error.
> 719:     if (tmp != nullptr) {
> 720:       log_debug(os)("Symbol %s not found in dll: %s", name, tmp);

Would log_warning be more suitable?

src/hotspot/os/windows/os_windows.cpp line 1288:

> 1286:     char buf[512];
> 1287:     if (os::lasterror(buf, sizeof(buf)) > 0) {
> 1288:       log_debug(os)("Symbol %s not found in dll: %s", name, buf);

similar here.

-------------

Marked as reviewed by mli (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18404#pullrequestreview-1988480081
PR Review Comment: https://git.openjdk.org/jdk/pull/18404#discussion_r1557240901
PR Review Comment: https://git.openjdk.org/jdk/pull/18404#discussion_r1557241038