RFR: 8327621: Check return value of uname in os::get_host_name [v2]

Johan Sjölen jsjolen at openjdk.org
Tue Apr 9 14:40:35 UTC 2024


On Thu, 28 Mar 2024 07:58:58 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Perform correct check and log warning
>
> src/hotspot/os/posix/os_posix.cpp line 618:
> 
>> 616:     return true;
>> 617:   }
>> 618:   const char* errmsg = os::strerror(retcode);
> 
> That should be `errno` not `retcode`.

Of course. Thank you for noticing and commenting.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18157#discussion_r1557758753


More information about the hotspot-runtime-dev mailing list