RFR: 8309751: Duplicate constant pool entries added during default method processing [v5]
Matias Saavedra Silva
matsaave at openjdk.org
Tue Apr 9 20:09:01 UTC 2024
On Tue, 9 Apr 2024 14:06:39 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> This uses Ashutosh's patch to avoid adding duplicate constant pool entries during default method processing, with one change to make it conditional if not needed. I tested this locally and started writing a test, but writing a test is more difficult because duplicate constant pool entries don't actually violate the spec.
>>
>> Tested with tier1-4 and ran some startup performance benchmarks on the patch.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Removed unused local var.
Thanks for the changes, looks good!
-------------
Marked as reviewed by matsaave (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18548#pullrequestreview-1990057653
More information about the hotspot-runtime-dev
mailing list