RFR: 8327621: Check return value of uname in os::get_host_name [v3]

David Holmes dholmes at openjdk.org
Wed Apr 10 02:33:02 UTC 2024


On Tue, 9 Apr 2024 14:40:35 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi,
>> 
>> Trivial bug fix where we didn't check the return value of `uname(2)` on POSIX platforms. I checked callers of `get_host_name` and all wrap the calls in an `if` branch so they already handle failures.
>> 
>> Regards,
>> Johan
>
> Johan Sjölen has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Remove saved_errno
>  - Save the errno and use

LGTM thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18157#pullrequestreview-1990659180


More information about the hotspot-runtime-dev mailing list