RFR: 8324683: Unify AttachListener code for Posix platforms [v3]

[Thomas Stuefe]

On Thu, 11 Apr 2024 21:46:27 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Maybe you could take my stuff and consolidate it with yours so we can get closer to the number of lines deleted that my PR has, or even beat it :-)?
> 
> All the best, Johan

Hi @jdksjolen,

Duplicate work is always annoying, sorry. To our defense, @SoniaZaldana 's work has been going on for many weeks now out in the open.

I advised her to leave AIX out of the patch for several reasons:

When analyzing the differences, we found a number of sublteties that may break AIX, and we have no easy way to check that platform. From my time as AIX porter I remember that the attach listener framework on AIX was brittle and took a lot of grooming to get right. 

Since the current AIX porters are really overworked atm and the last thing they need are regressions, I would leave the AIX code base as it is for now. Let the porters deal with this if/when they find time.  Importantly, they then also can double-check whether many of the old workarounds we added back in the early 2000's (eg those close/shutdown workarounds) are still needed in modern AIX versions.

Therefore, I would rather see Sonia's patch in its current form go in.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18283#issuecomment-2051025823