RFR: 8324683: Unify AttachListener code for Posix platforms [v3]

[Martin Doerr]

On Fri, 12 Apr 2024 15:11:49 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Thanks for the comments folks and sorry to hear about the duplicate work @jdksjolen! 
>> 
>> @coleenp, Happy to make the name change from Posix -> Nix if that is more appropriate. 
>> 
>> Are there any other changes I should be aware of before pushing the updates? I can hold off until next week if that gives the AIX folks some time to catch up with the discussion.
>
>> > Hi @SoniaZaldana, something is off. Did you forget to push the deletion of the linux variant?
>> 
>> Hi @tstuefe, I deleted it and created a new file (attachListener_posix.cpp) but git picked it up as a file rename. Is this what you mean?
> 
> Oh, okay. How annoying of git :)
> 
> Okay then.

@tstuefe: I guess you meant "Fine by me! I do think that the credentials checks could be moved out-of-line into something like pd_check_credentials to remove clutter from the main code." by "Johan's nits"?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18283#issuecomment-2059727875