RFR: 8324683: Unify AttachListener code for Posix platforms [v3]

[Thomas Stuefe]

On Tue, 16 Apr 2024 18:48:16 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>>> > Hi @SoniaZaldana, something is off. Did you forget to push the deletion of the linux variant?
>>> 
>>> Hi @tstuefe, I deleted it and created a new file (attachListener_posix.cpp) but git picked it up as a file rename. Is this what you mean?
>> 
>> Oh, okay. How annoying of git :)
>> 
>> Okay then.
>
> @tstuefe: I guess you meant "Fine by me! I do think that the credentials checks could be moved out-of-line into something like pd_check_credentials to remove clutter from the main code." by "Johan's nits"?

> @TheRealMDoerr , @tstuefe, @SoniaZaldana
> 
> Yeah, I really don't want the `Nix` naming. I only meant the `pd` functions, which Sonia can bring in if she wants to. Sorry Sonia!!!

Mhhm. Lets just finish this one. @jdksjolen feel free to do any subsequent renaming on the next cleanup patch you were planning.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18283#issuecomment-2061191283