RFR: 8330464: hserr generic events - add entry for the before_exit calls [v2]

[Matthias Baesken]

On Thu, 18 Apr 2024 07:10:09 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   adjust comment in threads.cpp
>
> src/hotspot/share/runtime/threads.cpp line 836:
> 
>> 834: // Threads::destroy_vm() is normally called from jni_DestroyJavaVM() when
>> 835: // the program falls off the end of main(). Another VM exit path is through
>> 836: // vm_exit() when
> 
> I think you have to read it like this:
> 
> 
> Exit Path 1: reaching from Threads::destroy_vm()
> 
> Exit Path 2: reaching from
>     - vm_exit()
>     - System.exit()
>     - Serious error
> 
> 
> Maybe add commas to disambiguate.
> (https://en.wikipedia.org/wiki/Serial_comma)

I adjusted the comment and brought back the deleted part.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18809#discussion_r1570173696