RFR: 8330520: linux clang build fails in os_linux.cpp with static_assert with no message is a C++17 extension [v2]
Martin Doerr
mdoerr at openjdk.org
Thu Apr 18 09:50:02 UTC 2024
On Wed, 17 Apr 2024 15:41:28 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> We run into the following build error when compiling on Linux ppc64le with the clang toolchain
>>
>>
>> jdk/src/hotspot/os/linux/os_linux.cpp:2975:65: error: 'static_assert' with no message is a C++17 extension [-Werror,-Wc++17-extensions]
>> static_assert(MADV_POPULATE_WRITE == MADV_POPULATE_WRITE_value);
>>
>>
>> Currently it is not clear when "8314488: Compile the JDK as C++17" will be in the codebase so better fix the static_assert .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> use STATIC_ASSERT
LGTM.
-------------
Marked as reviewed by mdoerr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18816#pullrequestreview-2008386648
More information about the hotspot-runtime-dev
mailing list