RFR: 8330051: Small ObjectMonitor spinning code cleanups [v4]

Axel Boldt-Christmas aboldtch at openjdk.org
Thu Apr 18 14:23:59 UTC 2024


On Thu, 18 Apr 2024 14:20:38 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> src/hotspot/share/runtime/objectMonitor.hpp line 358:
>> 
>>> 356: 
>>> 357: 
>>> 358:   enum class TryLockResult { CasFailed = -1, HasOwner = 0, Success = 1};
>> 
>> Maybe "Failed" instead of "CasFailed" for consistency, since we don't call the success "CasSuccess".
>
> Might even call it `Interference`. The way it is used is to signal to the spin code that we observed an unlocked monitor, but our locking was interfered with.

Or `Contention`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18730#discussion_r1570866536


More information about the hotspot-runtime-dev mailing list