RFR: 8329351: add runtime/Monitor/TestRecursiveLocking.java for recursive Java monitor stress testing

Daniel D. Daugherty dcubed at openjdk.org
Thu Apr 18 21:32:56 UTC 2024


On Tue, 9 Apr 2024 19:31:14 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> The first stress test to be added is:
>> 
>> runtime/Monitor/TestRecursiveLocking.java
>> 
>> It has been tested with a couple of 12 hour runs on my MBP13:
>>   - 3 build configs: release, fastdebug, slowdebug, 4 hours each, total 12 hours
>>   - 18 test configs, 800 seconds each, total 4 hours
>> 
>> The default configuration has been tested in Mach5 Tier2 and the
>> StressWrapper_TestRecursiveLocking_36M.java version has been
>> tested in Mach5 Tier3.
>
> test/hotspot/jtreg/runtime/Monitor/TestRecursiveLocking.java line 517:
> 
>> 515: 
>> 516:     public void waitForStart() {
>> 517:         synchronized(waiter) {
> 
> Suggestion:
> 
>         synchronized (waiter) {

Thanks for catching this. I fixed a total of 6 instances.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18664#discussion_r1571405949


More information about the hotspot-runtime-dev mailing list