RFR: 8329351: add runtime/Monitor/TestRecursiveLocking.java for recursive Java monitor stress testing
Daniel D. Daugherty
dcubed at openjdk.org
Thu Apr 18 21:59:58 UTC 2024
On Thu, 11 Apr 2024 23:08:10 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> The first stress test to be added is:
>>
>> runtime/Monitor/TestRecursiveLocking.java
>>
>> It has been tested with a couple of 12 hour runs on my MBP13:
>> - 3 build configs: release, fastdebug, slowdebug, 4 hours each, total 12 hours
>> - 18 test configs, 800 seconds each, total 4 hours
>>
>> The default configuration has been tested in Mach5 Tier2 and the
>> StressWrapper_TestRecursiveLocking_36M.java version has been
>> tested in Mach5 Tier3.
>
> test/hotspot/jtreg/runtime/Monitor/TestRecursiveLocking.java line 255:
>
>> 253: }
>> 254: if (LockingMode != LM_LEGACY) {
>> 255: assertInflated();
>
> Legacy isn't inflated because it's recursive? Can you add a comment why? It would help if something changes and the test starts failing to help whoever breaks this.
I'm adding comments for most of the assertions.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18664#discussion_r1571434679
More information about the hotspot-runtime-dev
mailing list