RFR: 8329351: add runtime/Monitor/TestRecursiveLocking.java for recursive Java monitor stress testing
Daniel D. Daugherty
dcubed at openjdk.org
Fri Apr 19 20:38:28 UTC 2024
On Thu, 18 Apr 2024 21:35:26 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
>> test/hotspot/jtreg/runtime/Monitor/TestRecursiveLocking.java line 212:
>>
>>> 210: public class TestRecursiveLocking {
>>> 211: static final WhiteBox WB = WhiteBox.getWhiteBox();
>>> 212: static final int LockingMode = WB.getIntVMFlag("LockingMode").intValue();
>>
>> Variables in Java are supposed to start with lower case letters and be camel case so it's sort of clear that you've read this into the Java code. ie. it's the Java version of the variable not the VM version.
>
> I like the typography of `LockingMode` because a grep will find it so...
> I changed all uses of the `LockingMode` flag variable to `flagLockingMode`.
I've also changed `LockStackCapacity` to `constLockStackCapacity`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18664#discussion_r1572927232
More information about the hotspot-runtime-dev
mailing list