RFR: 8330849: Add test to verify memory usage with recursive locking [v2]

Roman Kennke rkennke at openjdk.org
Mon Apr 22 21:02:27 UTC 2024


On Mon, 22 Apr 2024 19:50:49 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make test less restrictive
>
> test/hotspot/jtreg/runtime/locking/TestRecursiveMonitorChurn.java line 57:
> 
>> 55:             }
>> 56:         } else {
>> 57:             ProcessBuilder pb = ProcessTools.createLimitedTestJavaProcessBuilder(
> 
> Are there any reasons to use createLimitedTestJavaProcessBuilder here?
> If test should work with C1/C2 and different locking modes then it would be better just to use createTestJavaProcessBuilder and don't use 'TieredStopAtLevel'. So the test could be executed with C1/C2, different GC, and any other VM flags.
> They should be combined with test vm options.

createLimitedTestJavaProcessBuilder is a copy+paste mistake ;-) Running with TieredStopAtLevel is intentional, I think C2 would eliminate the locks and might lead to false positives. OTOH, the test would run long enough in interpreter and C1 to still exceed the monitor threshold, so should be ok.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18899#discussion_r1575353065


More information about the hotspot-runtime-dev mailing list