RFR: 8324683: Unify AttachListener code for Posix platforms [v4]

David Holmes dholmes at openjdk.org
Tue Apr 23 08:07:42 UTC 2024


On Tue, 23 Apr 2024 02:56:19 GMT, David Holmes <dholmes at openjdk.org> wrote:

> It is not perfect in achieving that but it most definitely is not intended to mean Unix, nor just non-Windows!

My apologies - I have to eat some "humble pie" here. When os_posix.hpp was introduced by [JDK-7165755](https://bugs.openjdk.org/browse/JDK-7165755) it was in fact `os_not-windows.hpp` but we evolved it to provide shared Posix-compliant implementations of various OS methods to be used by any Posix-compliant platform. As I said it is not perfect in that regard and we have a number of ifdefs for platform specific tweaks so we can maximise code sharing.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18283#issuecomment-2071677190


More information about the hotspot-runtime-dev mailing list