RFR: 8330989: unify os::create_binary_file across platforms [v2]

David Holmes dholmes at openjdk.org
Wed Apr 24 10:45:32 UTC 2024


On Wed, 24 Apr 2024 08:03:52 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Seems os::create_binary_file can be unified across Posix platforms. Windows is also rather similar and can be included.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   unify windows as well

Sorry @MBaesken I led you astray - I missed the fact that on Windows all the flag constants also start with `_` so `_O_CREAT` instead of `O_CREAT`. etc. If the non-underscore versions exist they will likely generate a compiler warning.

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18918#pullrequestreview-2019518925


More information about the hotspot-runtime-dev mailing list