RFR: 8329850: [AIX] Allow loading of different members of same shared library archive [v3]

[Joachim Kern]

On Thu, 25 Apr 2024 13:15:53 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Joachim Kern has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   cosmetic changes
>
> src/hotspot/os/aix/porting_aix.cpp line 1069:
> 
>> 1067:           (p_handletable + i)->inode == libstat.st_ino &&
>> 1068:           (p_handletable + i)->devid == libstat.st_dev &&
>> 1069:           (((p_handletable + i)->member == member) ||
> 
> If this ever fires (wildly unlikely), its a bug. You are comparing a stack address with something that lives in C heap right now.

I discussed this with Martin. The meaning of the line is: Check if both are nullptr.
My original implementation was:
(((p_handletable + i)->member == nullptr && member == nullptr) ||
Martin favoured the shorter version above which will have the same result.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18676#discussion_r1579477928