RFR: 8329850: [AIX] Allow loading of different members of same shared library archive [v3]
Martin Doerr
mdoerr at openjdk.org
Thu Apr 25 14:40:55 UTC 2024
On Thu, 25 Apr 2024 14:30:57 GMT, Joachim Kern <jkern at openjdk.org> wrote:
>> It is, to me, not obvious where the member is reset. We delete it, but don't set the pointer to NULL.So, its not obvious that entry->member could not point to a former stale c heap address.
>>
>> In any case, I prefer the cleanly written out logic. The generated code will be the same anyway, so this brevity just obfuscates your intent and confuses casual readers.
>
> Back to the roots.
I think that Thomas' point is that `member = nullptr;` is missing after the `free` operation. I agree with that.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18676#discussion_r1579584516
More information about the hotspot-runtime-dev
mailing list