RFR: 8315431: ArchiveHeapWriter::get_filler_size_at() cannot handle buffer expansion
Matias Saavedra Silva
matsaave at openjdk.org
Thu Apr 25 15:26:34 UTC 2024
On Tue, 23 Apr 2024 15:47:46 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> In `ArchiveHeapWriter::maybe_fill_gc_region_gap()`:
>
> - The address of `filler` will change if the buffer (which is a GrowableArrayCHeap) expands.
> - Instead of storing the address, we store the offset of `filler` from the beginning of the buffer. This offset will not change even if the buffer expands.
LGTM!
-------------
Marked as reviewed by matsaave (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18920#pullrequestreview-2022887647
More information about the hotspot-runtime-dev
mailing list