RFR: 8330989: unify os::create_binary_file across platforms [v2]

[David Holmes]

On Thu, 25 Apr 2024 13:46:37 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Hi David, no compile or test errors have been observed in GHA or in our internal testing. So should we keep what we have? Or go for the '_' prefixed flags and _open on Windows ?

Okay. Based on this:

https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/open?view=msvc-170
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4996?view=msvc-170#posix-function-names

I expected to see compiler deprecation warningsm as AFAICS we don't disable them. ??

If this works then I guess it is okay.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18918#issuecomment-2078736699