RFR: 8330989: unify os::create_binary_file across platforms [v2]

Fri Apr 26 07:45:36 UTC 2024

On Fri, 26 Apr 2024 07:36:52 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Maybe for some strange reason 'open' is bad but '::open' is okay for MSVC

btw. should we maybe better use `os::open`  instead or was there a special reason not to do it here ?
The Windows os::open already adds  O_BINARY, see https://github.com/openjdk/jdk/blob/a407dc9cbb48c4f66af51433067925605d3bc39d/src/hotspot/os/windows/os_windows.cpp#L4816
 so there would be no need for this Win-only special handling any more.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18918#issuecomment-2078816881