RFR: 8330989: unify os::create_binary_file across platforms [v2]

[Matthias Baesken]

On Wed, 24 Apr 2024 08:03:52 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Seems os::create_binary_file can be unified across Posix platforms. Windows is also rather similar and can be included.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   unify windows as well

okay the let's NOT use `os::open` .
Regarding recommended  `_open` vs,  `::open`  on Windows, we used `::open`  before in `create_binary_file`   , so this should be fine and is just the same code moved to os.cpp . 
Regarding the flags, they exist on Windows with and without leading ` _`  - any reason to go to the versions with leading ` _`  ?
I can do so if you want but it would only add ifdefs to the code .

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18918#issuecomment-2082469115