RFR: 8337662: Improve os::print_hex_dump for printing Instructions sections

[Matthias Baesken]

On Thu, 1 Aug 2024 14:26:06 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Hi Matthias,
> 
> this is useful.
> 
> We need some gtests for this:
> 
> * test with logical_address = nullptr, and highlighted address at the start/middle/end of a hex line
> * test with logical_address != nullptr, and highlighted address should then correspond to the logical address

Hi Thomas, do you have some good existing place where to place the test ?
Btw currently only start of line is  'highlighted'  , but for printing the instruction sections this is  sufficient because the pc  is located at a line start,

Should I change this to support also highlighting if it is somewhere in the middle of the line ?
If so,  there would be several options, e.g. for 'highlighting'  AA  located in the middle of line
just print
`=> <hexaddress>:  44 55 66 77 88 AA  BB CC `

or maybe use 2 lines ?
`   <hexaddress>:  44 55 66 77 88 `
`=>                              AA BB CC`

or something like this ?
`=> <hexaddress>:  44 55 66 77 88 |AA|  BB CC `

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20419#issuecomment-2264810815