RFR: 8337662: Improve os::print_hex_dump for printing Instructions sections

Fri Aug 2 12:43:32 UTC 2024

On Fri, 2 Aug 2024 11:13:25 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> We have tests for hex dumping, I think in gtest/os/test_os.cpp (or somewhere there). Adding your case should be not that hard.

Thanks, I'll look at this.

> I think start of the line is fine.

Yeah it is simple and does not mess up the copy-paste to assembler tools too much.
I also thought about 'mixing in'  the function/method start location info (we usually/often have this info in the hserr/crash case); but this would also make the copy-paste a bit more work.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20419#issuecomment-2265290064