RFR: 8337662: Improve os::print_hex_dump for printing Instructions sections [v2]

[Matthias Baesken]

On Tue, 6 Aug 2024 18:24:01 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   simplify coding
>
> src/hotspot/share/runtime/os.cpp line 1049:
> 
>> 1047:       // highlight start of line if address of interest is located there
>> 1048:       bool should_highlight = false;
>> 1049:       if (highlight_address == p) should_highlight = true;
> 
> Would this not still be restricted to highlighting if the address matches the start of the line? Would you not need something like this instead (not tested):
> 
> 
> if (highlight_address >= p && highlight_address < p + cols_per_line/unitsize)

Hi Thomas, the coding is now

`if (highlight_address >= p && highlight_address < p + cols_per_line) should_highlight = true;`

Seems you check an old revision ?

And the gtest tests now also  `from+60`  which is not at a line start .

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20419#discussion_r1706511022