RFR: 8337622: IllegalArgumentException in java.lang.reflect.Field.get [v2]

[Coleen Phillimore]

On Thu, 8 Aug 2024 04:57:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix copyright lines.
>
> src/hotspot/share/classfile/javaClasses.cpp line 1467:
> 
>> 1465: void java_lang_Class::serialize_offsets(SerializeClosure* f) {
>> 1466:   f->do_bool(&_offsets_computed);
>> 1467:   f->do_u4((u4*)&_init_lock_offset);
> 
> I can't figure out exactly what this code does and why the old code needed this to be explicit. ??

The reason that we needed the line is because the field isn't injected and CDS needed a way to find the value for _init_lock_offset too.   Now that it's injected, the offset will be filled in like the rest.  See line 1464.

> test/hotspot/jtreg/runtime/reflect/ComponentTypeFieldTest.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2014, 2021, Oracle and/or its affiliates. All rights reserved.
> 
> New test should only have 2024 copyright year?

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20498#discussion_r1709901640
PR Review Comment: https://git.openjdk.org/jdk/pull/20498#discussion_r1709900352