RFR: 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058

Matthias Baesken mbaesken at openjdk.org
Fri Aug 9 08:59:33 UTC 2024


On Fri, 9 Aug 2024 08:14:03 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> After [JDK-8338058](https://bugs.openjdk.org/browse/JDK-8338058) by mistake an old assertion remained in map_or_reserve_memory_aligned; this has to be removed.
>
> src/hotspot/os/windows/os_windows.cpp line 3466:
> 
>> 3464: 
>> 3465:   assert(aligned_base != nullptr,
>> 3466:        "Did not manage to re-map after %d attempts (size %zu, alignment %zu, file descriptor %d)", max_attempts, size, alignment, file_desc);
> 
> 5 spaces indentation looks strange.

okay should I use  one less (like in the other asserts at the start of the method) ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20519#discussion_r1711086459


More information about the hotspot-runtime-dev mailing list