RFR: 8338110: exclude Fingerprinter::do_type from ubsan checks

Afshin Zafari azafari at openjdk.org
Fri Aug 9 19:18:32 UTC 2024


On Fri, 9 Aug 2024 11:53:38 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> For now we still have undefined behavior in Fingerprinter::do_type reported by ubsan ; exclude the method from ubsan checks until the signature handling code is adjusted .
> 
> With this change I can finally build with ubsan enabled, without special additional setting (using gcc devkit11.3.0 , on Linux x86_64).

Sorry to intervene here. I have seen this UBSAN error while I was working on another UBSAN case. Are you sure that this is really a false positive case? The `_shift_count` goes to 65 at error time which means that it is incremented too much in one of the calls to `do_type`. Are we sure that the call should not happen or should we handle the case where `_shift_count` exceeds the 64?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20522#issuecomment-2278589747


More information about the hotspot-runtime-dev mailing list