RFR: 8336148: Test runtime/locking/TestRecursiveMonitorChurn.java failed: Unexpected Inflation [v2]

David Holmes dholmes at openjdk.org
Mon Aug 12 23:22:49 UTC 2024


On Mon, 12 Aug 2024 16:05:04 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> When writing the test I suspected that this might happen.
>> 
>> I wanted to see if we could get away without a fuzz factor on the post and pre inflation comparison.
>> 
>> I'll update the test with a fuzz factor that can handle that some spurious inflation from other sources can occur. Especially relevant now that class loading uses an ObjectLocker, which is why it occurred when instrumentation was added and not only with the -XX:+DeoptimizeALot flags.
>> 
>> Will run through the problematic tests and check that these help. All observed occurrences have been with a difference of one between pre and post inflation counts.
>
> Axel Boldt-Christmas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove superfluous whitespace

Seems reasonable. Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20551#pullrequestreview-2234173395


More information about the hotspot-runtime-dev mailing list