RFR: 8337318: Deoptimization::relock_objects fails assert(monitor->owner() == Thread::current()) failed: must be [v3]

[David Holmes]

On Mon, 12 Aug 2024 19:59:46 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> The assert is wrong.  During deoptimization, the locking_thread is not the current thread, and that's the thread we should assert is the owner.
>> Reproduced in tier8 with com/sun/jdi/EATests.java, with LockStack CAPACITY=1 and not reproduced with the fix.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update SAP copyright.

Looks good. Somewhat surprising we didn't hit this sooner, but now we at least have test coverage.

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20553#pullrequestreview-2234274885