RFR: 8337595: Remove empty statements in src/hotspot/share/memory/metaspace

David Holmes dholmes at openjdk.org
Tue Aug 13 01:20:49 UTC 2024


On Mon, 12 Aug 2024 15:03:55 GMT, Casper Norrbin <duke at openjdk.org> wrote:

> Hi everyone,
> 
> Some of the macro definitions in `metaspaceCommon.hpp` include semicolons, resulting in empty statements being inserted when invoked. This behavior is unclear and could potentially lead to bugs.
> 
> This PR removes the semicolons from these macros, aligning them with other metaspace macros.

Looks good. Thanks for cleaning it up.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20552#pullrequestreview-2234282448


More information about the hotspot-runtime-dev mailing list