RFR: 8337987: Relocate jfr and throw_exception stubs from StubGenerator to SharedRuntime [v2]

Andrew Dinn adinn at openjdk.org
Tue Aug 13 21:38:10 UTC 2024


On Tue, 13 Aug 2024 19:52:05 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Andrew Dinn has updated the pull request incrementally with six additional commits since the last revision:
>> 
>>  - copy macro across
>>  - typo
>>  - fix frame layouts for x86_32
>>  - fix throw exception stub generation on zero
>>  - fix some header includes and defintions
>>  - fix issues with ports
>
> src/hotspot/cpu/x86/stubGenerator_x86_32.cpp line 3917:
> 
>> 3915:     StubRoutines::x86::_d2l_wrapper                = generate_d2i_wrapper(T_LONG, CAST_FROM_FN_PTR(address, SharedRuntime::d2l));
>> 3916: 
>> 3917:       CAST_FROM_FN_PTR(address, SharedRuntime::throw_delayed_StackOverflowError));
> 
> This does not seems correct. And I see linux-x86 (32 bits) corresponding build failure in GHA.

Sorry, that was an accidental paste while editing the code. Should be fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20566#discussion_r1715953549


More information about the hotspot-runtime-dev mailing list