RFR: 8338550: Do libubsan1 installation in test container only on Ubuntu

Severin Gehwolf sgehwolf at openjdk.org
Mon Aug 19 12:05:47 UTC 2024


On Mon, 19 Aug 2024 11:11:26 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> After [JDK-8333144](https://bugs.openjdk.org/browse/JDK-8333144) docker related tests do not work on manually configured distros other than the 'standard' Ubuntu. This is because the basic generated Dockerfile with the change from [JDK-8333144](https://bugs.openjdk.org/browse/JDK-8333144) assumes 'apt-get' being available, which is not the case when one runs the testing on RPM based distributions.
> So let's limit the libubsan1 installation to Ubuntu;  also add an 'apt-get update' to get recent package lists.

Could we not make this configurable so that `libubsan1` only gets installed when it's actually needed? This still installs it on every container build (i.e. per docker test) on `ubuntu` based images.

-------------

PR Review: https://git.openjdk.org/jdk/pull/20624#pullrequestreview-2245371908


More information about the hotspot-runtime-dev mailing list