RFR: 8337662: Improve os::print_hex_dump for printing Instructions sections [v5]

Lutz Schmidt lucy at openjdk.org
Mon Aug 19 12:42:52 UTC 2024


On Tue, 6 Aug 2024 15:33:44 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Currently we use os::print_hex_dump for printing Instruction sections in the hserr file. The function could be slightly improved, .e.g. by showing directly the pc .
>> The instructions section would for example look like this, with a small helper '=>' pointing to the pc. Makes the output more readable.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add gtest

With the suggestions from @TheRealMDoerr considered, changes look good to me.

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20419#pullrequestreview-2245443039


More information about the hotspot-runtime-dev mailing list