RFR: 8313395: LotsUnloadTest.java fails with OOME transiently with libgraal

Doug Simon dnsimon at openjdk.org
Wed Aug 21 08:48:04 UTC 2024


On Tue, 20 Aug 2024 19:24:21 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Permanent test filtering makes sense in this case since "the purpose of this test is neither to test libgraal nor Xcomp".
>
> ough, I thought that it is temporary.
> I don't think "the purpose of this test is neither to test libgraal nor Xcomp" is good enough reason to don't run test. There are a lot of tests that have not a purpose to tests graal/Xcomp or any other specific mode. However sometimes they are failing and finding product issues. The test dump archive and try to reuse it . I don't see why this shouldn't be tested with Graal + Xcomp in general.
> If test requires more memory with Graal then it makes sense to split itge Graal-specific testcase with higher Xmx. 
> If test couldn't be fixed to be work with Graal (or any other particular mode) or you think it is unreasonably hard to fix it then it is fine to use requires. Please just add explanation in the bug or PR.
> The another valid reason is to exclude specific configuration if there is no corresponding problemlist.

I'll leave it up to you Ioi as to how to proceed. As the conversation in [JDK-8313395](https://bugs.openjdk.org/browse/JDK-8313395) indicates, this is not a libgraal problem.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20648#discussion_r1724678172


More information about the hotspot-runtime-dev mailing list