RFR: 8338902: CDS flags are reported with wrong flag category

[Aleksey Shipilev]

Noticed this little oddity when looking through Leyden crash reports:


$ build/macosx-aarch64-server-fastdebug/images/jdk/bin/java -XX:+PrintFlagsFinal 2>&1 | grep ArchiveRelocationMode  
      int ArchiveRelocationMode                    = 1                                {JVMCI diagnostic} {default}


Depending on build, these flags seem to be attributed to different categories. I think this bug also skews all other flag categories, since we don't account for CDS flags being in the middle of the table here: https://github.com/openjdk/jdk/blob/916f1aa04f6fcc6da9bf9d725e3639cf4c0755a1/src/hotspot/share/runtime/flags/allFlags.hpp#L60-L66. My initial patch was to introduce the `CDS` category, but I think that is excessive. We can just move the CDS flags below the specialized flags, so they are reported as "other", i.e. without a category.

After the fix:


% build/macosx-aarch64-server-fastdebug/images/jdk/bin/java -XX:+PrintFlagsFinal 2>&1 | grep ArchiveRelocationMode
      int ArchiveRelocationMode                    = 1                                      {diagnostic} {default}

-------------

Commit messages:
 - Just move CDS flags a bit down
 - Fix

Changes: https://git.openjdk.org/jdk/pull/20692/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20692&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8338902
  Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/20692.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20692/head:pull/20692

PR: https://git.openjdk.org/jdk/pull/20692