RFR: 8338888: SystemDictionary::class_name_symbol has incorrect length check

[Coleen Phillimore]

On Mon, 26 Aug 2024 02:49:42 GMT, David Holmes <dholmes at openjdk.org> wrote:

> The name length check was incorrectly truncating the length to an int, which is wrong if the name is > `INT_MAX`. Added a test for this case to the existing test cases and fixed an issue with the call to `Exceptions::fthrow` that can hit the `INT_MAX` limitations of `os::vsnprintf` (this is the first in a serious of fixes that will mainly be done under [JDK-8328882](https://bugs.openjdk.org/browse/JDK-8328882) or subtasks thereof).
> 
> Testing:
>  - updated test
>  - tiers 1-3 (sanity)
> 
> Thanks

Looks good.

test/hotspot/jtreg/runtime/exceptionMsgs/NoClassDefFoundError/libNoClassDefFoundErrorTest.c line 67:

> 65:         return JNI_TRUE;
> 66:     }
> 67:     return JNI_FALSE;

You don't free the class name so that the memory is available to the error message?  Maybe a comment would be useful here and below.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20709#pullrequestreview-2261286614
PR Review Comment: https://git.openjdk.org/jdk/pull/20709#discussion_r1731613700