RFR: 8338888: SystemDictionary::class_name_symbol has incorrect length check

David Holmes dholmes at openjdk.org
Mon Aug 26 20:52:06 UTC 2024


On Mon, 26 Aug 2024 18:05:51 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> The name length check was incorrectly truncating the length to an int, which is wrong if the name is > `INT_MAX`. Added a test for this case to the existing test cases and fixed an issue with the call to `Exceptions::fthrow` that can hit the `INT_MAX` limitations of `os::vsnprintf` (this is the first in a serious of fixes that will mainly be done under [JDK-8328882](https://bugs.openjdk.org/browse/JDK-8328882) or subtasks thereof).
>> 
>> Testing:
>>  - updated test
>>  - tiers 1-3 (sanity)
>> 
>> Thanks
>
> Looks good.

Thanks for the review @coleenp .

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20709#issuecomment-2311068831


More information about the hotspot-runtime-dev mailing list