RFR: 8338888: SystemDictionary::class_name_symbol has incorrect length check
Coleen Phillimore
coleenp at openjdk.org
Mon Aug 26 21:14:03 UTC 2024
On Mon, 26 Aug 2024 20:49:36 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Since the test is run with othervm, the memory should be reclaimed with the process exit. Probably no comment needed since I think we can't run native code without othervm.
>
> We can run native code without othervm but I switched to othervm both for the logging and to make it more likely we would not be short on memory.
>
> The malloc'd name is used to construct the error message but not used as part of the error message so can be freed once the JNI call is complete.
othervm seems like a good choice for this but now when you return JNI_FALSE, where do you free the string?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20709#discussion_r1731832474
More information about the hotspot-runtime-dev
mailing list