RFR: 8338888: SystemDictionary::class_name_symbol has incorrect length check

Thomas Stuefe stuefe at openjdk.org
Tue Aug 27 05:55:04 UTC 2024


On Tue, 27 Aug 2024 05:44:05 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> This seems fine.  You say what the 45 is for.
>
> Do you really want to throw an exception with a message length of up to 2 GB? This may find its way into logfiles etc. Even printing out 64K worth of name may be a bit much.

But `Exceptions::fthrow` truncates at 1024 bytes anyway, which I think is absolutely fine. So the print_limit could just be 1024.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20709#discussion_r1732161491


More information about the hotspot-runtime-dev mailing list