RFR: 8338929: Make Metaspace::deallocate space-aware [v2]

[Coleen Phillimore]

On Tue, 27 Aug 2024 13:14:08 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - improve comments
>>  - Merge branch 'master' into make-deallocate-space-aware
>>  - copyrights
>>  - fast is-in-class-space check
>
> src/hotspot/share/memory/metaspace.hpp line 121:
> 
>> 119: 
>> 120:   // Returns true if the pointer points into class space, non-class metaspace, or the
>> 121:   // Klass portion of the CDS archive.
> 
> This was the tiny comment nit.  This doesn't return the "Klass portion of the" CDS archive so can you remove those words?  Then it's good to go and I'll merge with it.  Thanks!

Oh, I see.  How about "metadata portion" then?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20701#discussion_r1733075935