RFR: 8338929: Make Metaspace::deallocate space-aware [v3]

Coleen Phillimore coleenp at openjdk.org
Tue Aug 27 15:33:07 UTC 2024


On Tue, 27 Aug 2024 15:25:23 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> For ucoming Lilliput changes, as well as to simplify [JDK-8338526](https://bugs.openjdk.org/browse/JDK-8338526), we should make Metaspace::deallocate space-aware (as in, instead of having to tell it where the pointed-to block resides, it should know it on its own). 
>> 
>> As of now, callers need to tell the function of the deallocated block is in class space or in non-class metaspace. That is unnecessary and won't work for TinyCP. The deallocation function can do this better on itself by doing a range check on the class space range.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   tiny comment change

Thank you!

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20701#pullrequestreview-2263775592


More information about the hotspot-runtime-dev mailing list