RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v2]

[Severin Gehwolf]

On Tue, 27 Aug 2024 14:28:31 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Had a look. I am no expert in these things, so this concentrates more on the mechanical parts and on readability.

Thanks very much for the review, @tstuefe!

> src/hotspot/os/linux/cgroupV2Subsystem_linux.hpp line 52:
> 
>> 50:                                             _path(o._path) {
>> 51:       _cgroup_path = o._cgroup_path;
>> 52:       _mount_point = o._mount_point;
> 
> I think the constructors should move to the C++ file.

Done.

> src/hotspot/os/linux/cgroupV2Subsystem_linux.hpp line 142:
> 
>> 140:                                          CgroupUtil::adjust_controller(memory))),
>> 141:                          _cpu(new CachingCgroupController<CgroupCpuController>(
>> 142:                                          CgroupUtil::adjust_controller(cpu))) {
> 
> I would move this to the C++ file.

Done.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20646#issuecomment-2313370298
PR Review Comment: https://git.openjdk.org/jdk/pull/20646#discussion_r1733422242
PR Review Comment: https://git.openjdk.org/jdk/pull/20646#discussion_r1733422498