RFR: 8338888: SystemDictionary::class_name_symbol has incorrect length check [v2]

[Kim Barrett]

On Wed, 28 Aug 2024 06:30:54 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> The name length check was incorrectly truncating the length to an int, which is wrong if the name is > `INT_MAX`. Added a test for this case to the existing test cases and fixed an issue with the call to `Exceptions::fthrow` that can hit the `INT_MAX` limitations of `os::vsnprintf` (this is the first in a serious of fixes that will mainly be done under [JDK-8328882](https://bugs.openjdk.org/browse/JDK-8328882) or subtasks thereof).
>> 
>> Testing:
>>  - updated test
>>  - tiers 1-3 (sanity)
>> 
>> Thanks
>
> David Holmes has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Use abridged form of class name in exception message as suggested by tstuefe
>  - Simplify memset as suggested by tstuefe

Looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20709#pullrequestreview-2265431141