RFR: 8337662: Improve os::print_hex_dump for printing Instructions sections [v6]
Thomas Stuefe
stuefe at openjdk.org
Wed Aug 28 14:25:20 UTC 2024
On Wed, 28 Aug 2024 14:12:15 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> > > Hi Thomas, I included your suggestions. Also I added a test with unit size 2 .
> >
> >
> > I think you need two variants of PAT_HL_1C though, one for big endian and one for little endian (yeah, this coding is annoyingly hard to get right and get tested on all platforms :( )
>
> Currently the whole test function(s) do_test_print_hex_dump and related is inside a large ` #ifndef AIX` so there is not really a big endian platform I could use to test. In theory you are of course correct.
I am quite sure SAP still executes tests on Linux ppcbe as well. At least that's what this https://github.com/openjdk/jdk/pull/20137#issuecomment-2225063573 comment suggests.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20419#issuecomment-2315481212
More information about the hotspot-runtime-dev
mailing list