RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v4]
Severin Gehwolf
sgehwolf at openjdk.org
Thu Aug 29 09:35:21 UTC 2024
On Thu, 29 Aug 2024 06:11:46 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> Okay from my side. The added complexity is regrettable, but I don't see an immediate way to reduce it.
Thanks for the review!
> src/hotspot/os/linux/cgroupSubsystem_linux.hpp line 216:
>
>> 214: virtual void set_subsystem_path(const char* cgroup_path) = 0;
>> 215: virtual char* mount_point() = 0;
>> 216: virtual char* cgroup_path() = 0;
>
> Please return const char*. Nobody should modify the contents of these strings from the outside via their pointers.
will do.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20646#issuecomment-2317155431
PR Review Comment: https://git.openjdk.org/jdk/pull/20646#discussion_r1735886525
More information about the hotspot-runtime-dev
mailing list