RFR: 8337662: Improve os::print_hex_dump for printing Instructions sections [v8]
Thomas Stuefe
stuefe at openjdk.org
Thu Aug 29 14:32:20 UTC 2024
On Thu, 29 Aug 2024 09:14:36 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Currently we use os::print_hex_dump for printing Instruction sections in the hserr file. The function could be slightly improved, .e.g. by showing directly the pc .
>> The instructions section would for example look like this, with a small helper '=>' pointing to the pc. Makes the output more readable.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> handle big endian JVMs in test
Good! Thanks for going the extra mile. If this passes the gtests on a BE platform of your choice, all is well.
-------------
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20419#pullrequestreview-2268978382
More information about the hotspot-runtime-dev
mailing list