RFR: 8311542: Consolidate the native stack printing code

David Holmes dholmes at openjdk.org
Mon Dec 2 12:07:24 UTC 2024


We now print native stacks in a number of contexts, not just VMError reporting, and we have to try `os::platform_print_native_stack` else fall back to `VMError::print_native stack`. 

The refactoring adds a new `NativeStackPrinter` (NSP) helper class which can be constructed with some of the context information for the printing that will follow. This avoids the need for the print functions to have a large number of parameters. We have to expose both the top-level printing functionality and the "lower-level" frame-based stack walk as the error reporter needs access to that directly. To maintain the exact same format of output the NSP has to be aware of some error reporter usage requirements.

I also had to expose a direct `frame` taking print function for the Debug.cpp `pns` case.

Testing:
 - tiers 1 - 4

Some frame management code was also moved from `VMError` to the `frame` class.

-------------

Commit messages:
 - Remove unused constructor
 - Missing file header
 - 8311542: Consolidate the native stack printing code

Changes: https://git.openjdk.org/jdk/pull/22472/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22472&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8311542
  Stats: 350 lines in 9 files changed: 231 ins; 96 del; 23 mod
  Patch: https://git.openjdk.org/jdk/pull/22472.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22472/head:pull/22472

PR: https://git.openjdk.org/jdk/pull/22472


More information about the hotspot-runtime-dev mailing list