Integrated: 8345012: os::build_agent_function_name potentially wastes a byte when allocating the buffer

[David Holmes]

On Wed, 27 Nov 2024 00:45:00 GMT, David Holmes <dholmes at openjdk.org> wrote:

> This is a minor issue noticed in the review of JEP 479. The calculations of the buffer length always do `+2` to allow for an optional underscore plus the terminator. A solution was suggested in that review (which I initially used) but I've instead opted for a solution where `name_len` always reflects the actual length of the lib name - otherwise we need to subtract the 1 again when doing the `strncat`. I also made the need for the underscore explicit. 
> 
> As the same code is used in os_posix.cpp both versions were made consistent. The only difference between them is the Windows version has to check for a drive specifier. I toyed with combining them into a shared version with a Windows-specific chunk, but opted for the simpler change. I can revisit that if people have strong opinions.
> 
> Testing
> - tiers 1-4
> 
> Thanks

This pull request has now been integrated.

Changeset: 3d0d0e62
Author:    David Holmes <dholmes at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3d0d0e62900653c4e395166a9ac48578b3dbc1f8
Stats:     155 lines in 3 files changed: 58 ins; 97 del; 0 mod

8345012: os::build_agent_function_name potentially wastes a byte when allocating the buffer

Reviewed-by: stuefe, shade

-------------

PR: https://git.openjdk.org/jdk/pull/22404